Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple elasticapm/opentracing #235

Merged
merged 1 commit into from
Sep 25, 2018
Merged

Decouple elasticapm/opentracing #235

merged 1 commit into from
Sep 25, 2018

Conversation

axw
Copy link
Member

@axw axw commented Sep 25, 2018

Introduce an internal package which is used
instead of using context.WithValue/context.Value
directly. By default those functions are used,
but when apmot is imported, it overrides their
use with the opentracing context functions,
wrapping all transactions and spans such that
they implement the opentracing.Span API.

Introduce an internal package which is used
instead of using context.WithValue/context.Value
directly. By default those functions are used,
but when apmot is imported, it overrides their
use with the opentracing context functions,
wrapping all transactions and spans such that
they implement the opentracing.Span API.
@codecov-io
Copy link

Codecov Report

Merging #235 into v2 will decrease coverage by 0.3%.
The diff coverage is 76.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v2     #235      +/-   ##
==========================================
- Coverage   80.67%   80.37%   -0.31%     
==========================================
  Files          88       91       +3     
  Lines        5295     5396     +101     
==========================================
+ Hits         4272     4337      +65     
- Misses        816      850      +34     
- Partials      207      209       +2
Impacted Files Coverage Δ
module/apmot/noop.go 100% <100%> (ø)
module/apmot/tracer.go 88.88% <100%> (+0.92%) ⬆️
gocontext.go 93.75% <100%> (ø) ⬆️
internal/apmcontext/context.go 100% <100%> (ø)
module/apmot/span.go 86.45% <100%> (-0.43%) ⬇️
module/apmot/wrapper.go 62.68% <62.68%> (ø)
module/apmot/context.go 86.95% <80%> (-13.05%) ⬇️
internal/fastjson/writer.go 68.83% <0%> (-2.6%) ⬇️
tracer.go 83.03% <0%> (-0.9%) ⬇️
model/marshal_fastjson.go 86.54% <0%> (-0.33%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99254e5...2e734e5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants