Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set GOSUMDB off #631

Closed
wants to merge 1 commit into from

Conversation

kuisathaverat
Copy link
Contributor

@kuisathaverat kuisathaverat commented Sep 4, 2019

Disable a new feature on go 1.13 that it is failing in the CI

closses #630

@kuisathaverat kuisathaverat self-assigned this Sep 4, 2019
@kuisathaverat
Copy link
Contributor Author

kuisathaverat commented Sep 4, 2019

The behavior changes after add GOPROXY=direct and GOSUMDB=off, now seems a dependencies issue

[2019-09-04T15:01:27.464Z] go: finding gopkg.in/src-d/go-git-fixtures.v3 v3.3.0
[2019-09-04T15:01:35.596Z] *** old
[2019-09-04T15:01:35.596Z] --- new
[2019-09-04T15:01:35.596Z] ***************
[2019-09-04T15:01:35.596Z] *** 3,5 ****
[2019-09-04T15:01:35.596Z] --- 3,7 ----
[2019-09-04T15:01:35.596Z]   require go.elastic.co/apm v1.5.0
[2019-09-04T15:01:35.596Z]   
[2019-09-04T15:01:35.596Z]   replace go.elastic.co/apm => /var/lib/jenkins/workspace/agent-go_apm-agent-go-mbp_PR-631/src/go.elastic.co/apm
[2019-09-04T15:01:35.596Z] + 
[2019-09-04T15:01:35.596Z] + go 1.13
[2019-09-04T15:01:35.596Z] 2019/09/04 15:01:34 exit status 1
[2019-09-04T15:01:35.596Z] exit status 1
[2019-09-04T15:01:35.596Z] Makefile:29: recipe for target 'check-modules' failed
[2019-09-04T15:01:35.596Z] make: *** [check-modules] Error 1

@axw I'd need your help here

@kuisathaverat kuisathaverat requested a review from axw September 4, 2019 15:09
@kuisathaverat kuisathaverat changed the title [WIP] fix: set GOSUMDB off fix: set GOSUMDB off Sep 4, 2019
@axw
Copy link
Member

axw commented Sep 5, 2019

I've fixed the issue in #629. The "genmod" program intentionally sets the proxy to an invalid hostname, to cause any attempt to download modules to fail - the idea being to ensure no dependencies are missing from our go.mod files. Go 1.13 changed some behaviour so that the "GOSUMDB" default was derived from GOPROXY.

@axw axw closed this Sep 5, 2019
@kuisathaverat kuisathaverat deleted the fix/go-1.13 branch September 5, 2019 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants