Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/hostutil: unescape systemd cgroup paths #672

Merged
merged 1 commit into from
Nov 12, 2019

Conversation

axw
Copy link
Member

@axw axw commented Nov 12, 2019

When k8s is using the systemd cgroup driver,
hyphens in pod UIDs will be escaped and translated
to underscores. We need to reverse this when
parsing the cgroup file.

See elastic/apm#165

When k8s is using the systemd cgroup driver,
hyphens in pod UIDs will be escaped and translated
to underscores. We need to reverse this when
parsing the cgroup file.
@codecov-io
Copy link

codecov-io commented Nov 12, 2019

Codecov Report

Merging #672 into master will decrease coverage by 0.39%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #672     +/-   ##
=========================================
- Coverage   87.96%   87.57%   -0.4%     
=========================================
  Files         124      124             
  Lines        8100     7821    -279     
=========================================
- Hits         7125     6849    -276     
- Misses        843      861     +18     
+ Partials      132      111     -21
Impacted Files Coverage Δ
internal/apmhostutil/container_linux.go 85.18% <100%> (ø) ⬆️
model/marshal_fastjson.go 75.59% <0%> (-4.68%) ⬇️
module/apmsql/pq/parser.go 78.78% <0%> (-3.72%) ⬇️
module/apmsql/conn.go 67.34% <0%> (-2.74%) ⬇️
module/apmsql/dsn.go 100% <0%> (ø) ⬆️
module/apmsql/mysql/parser.go 100% <0%> (ø) ⬆️
spancontext.go 100% <0%> (ø) ⬆️
module/apmgocql/observer.go 95.91% <0%> (+2.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9720dc3...8b54c39. Read the comment docs.

@axw axw merged commit 0365ba9 into elastic:master Nov 12, 2019
@axw axw deleted the k8s-systemd-unescape-pod-uid branch November 12, 2019 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants