Upgraded cucumber/godog v0.8.0 => v0.8.1, updated sum hashes. #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins run the tests please |
Codecov Report
@@ Coverage Diff @@
## master #733 +/- ##
==========================================
- Coverage 84.64% 84.60% -0.04%
==========================================
Files 127 127
Lines 8276 8278 +2
==========================================
- Hits 7005 7004 -1
- Misses 889 891 +2
- Partials 382 383 +1
Continue to review full report at Codecov.
|
|
Sorry, life was a bit hectic the last few days.
Yes, also tried nuking the GOPATH and the Go install. Anyway, 🥂 for merging it! |
|
I keep getting reports of this. Despite not being able to reproduce it myself, I'm going to create a patch release. Version numbers are free after all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason
cucumber/godog v0.8.0is/was causinggo mod SECURITY ERRORfor @euskadi31 (#732), @yinjun622 (#731) and me.Cause
The issue is only presenting itself on MacOS and seems te be caused by go#29278.
Go test
➜ go test ./... ok go.elastic.co/apm 0.134s [no tests to run] ? go.elastic.co/apm/apmconfig [no test files] ? go.elastic.co/apm/apmtest [no test files] ? go.elastic.co/apm/internal/apmcontext [no test files] ? go.elastic.co/apm/internal/apmgodog [no test files] ok go.elastic.co/apm/internal/apmhostutil 0.032s [no tests to run] ok go.elastic.co/apm/internal/apmhttputil 0.028s [no tests to run] ok go.elastic.co/apm/internal/apmlog 0.025s [no tests to run] ? go.elastic.co/apm/internal/apmschema [no test files] ok go.elastic.co/apm/internal/apmstrings 0.028s [no tests to run] ? go.elastic.co/apm/internal/apmversion [no test files] ok go.elastic.co/apm/internal/configutil 0.023s [no tests to run] ok go.elastic.co/apm/internal/iochan 0.029s [no tests to run] ? go.elastic.co/apm/internal/pkgerrorsutil [no test files] ok go.elastic.co/apm/internal/ringbuffer 0.026s [no tests to run] ok go.elastic.co/apm/internal/sqlscanner 0.027s [no tests to run] ? go.elastic.co/apm/internal/sqlutil [no test files] ok go.elastic.co/apm/internal/wildcard 0.028s [no tests to run] ok go.elastic.co/apm/model 0.020s [no tests to run] ? go.elastic.co/apm/scripts [no test files] ok go.elastic.co/apm/stacktrace 0.027s [no tests to run] ok go.elastic.co/apm/transport 0.015s [no tests to run] ? go.elastic.co/apm/transport/transporttest [no test files]Go env
GO111MODULE="" GOARCH="amd64" GOBIN="/Users/yekurtal/Desktop/Other/go/bin" GOCACHE="/Users/yekurtal/Library/Caches/go-build" GOENV="/Users/yekurtal/Library/Application Support/go/env" GOEXE="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="darwin" GOINSECURE="" GONOPROXY="" GONOSUMDB="" GOOS="darwin" GOPATH="/Users/yekurtal/Desktop/Other/go" GOPRIVATE="" GOPROXY="https://proxy.golang.org,direct" GOROOT="/usr/local/go" GOSUMDB="sum.golang.org" GOTMPDIR="" GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64" GCCGO="gccgo" AR="ar" CC="clang" CXX="clang++" CGO_ENABLED="1" GOMOD="/Users/yekurtal/Desktop/Projects/apm-agent-go/go.mod" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/qg/qmq8003505l_zhp_jqr1n4rh0000gn/T/go-build543883094=/tmp/go-build -gno-record-gcc-switches -fno-common"