Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added apmgoredisv8 module #780

Merged
merged 2 commits into from
Jun 4, 2020
Merged

Added apmgoredisv8 module #780

merged 2 commits into from
Jun 4, 2020

Conversation

idealism-xxm
Copy link
Contributor

Add support for go-redis/redis/v8

@cla-checker-service
Copy link

cla-checker-service bot commented Jun 3, 2020 •
edited
Loading

💚 CLA has been signed

axw
axw requested changes Jun 4, 2020
View reviewed changes
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, thanks! Just a couple of things I'd like simplified.

Please sign the CLA: https://www.elastic.co/contributor-agreement. We can't accept any contributions without it.

module/apmgoredisv8/hook.go Outdated Show resolved Hide resolved
module/apmgoredisv8/hook.go Outdated Show resolved Hide resolved
@apmmachine
Copy link
Contributor

apmmachine commented Jun 4, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [axw commented: jenkins run the tests please]

  • Start Time: 2020-06-04T06:02:04.732+0000

  • Duration: 26 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 7261
Skipped 182
Total 7443

@idealism-xxm @axw
fix(apmgoredisv8): rename hook type name; use apm.SpanFromContext to …
8f54a18 
…retrieve started span

Co-authored-by: Andrew Wilkins <axwalk@gmail.com>
@idealism-xxm
Copy link
Contributor Author

@axw All issues are fixed now. Please review it and let me know if I've missed anything.

axw
axw approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the updates! I'll just need to let CI run it through before merging.

I noticed that goredis/v8 hasn't had a 8.0.0 release yet – 8.0.0-beta2 is the most recent. Given that, I think we would consider this module experimental for now, meaning that the module's API might change in backwards-incompatible ways until goredis 8.0.0 is released.

@axw
Copy link
Member

axw commented Jun 4, 2020

jenkins run the tests please

@codecov-commenter
Copy link

Codecov Report

Merging #780 into master will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #780      +/-   ##
==========================================
+ Coverage   84.72%   84.81%   +0.09%     
==========================================
  Files         127      128       +1     
  Lines        8391     8417      +26     
==========================================
+ Hits         7109     7139      +30     
+ Misses        898      894       -4     
  Partials      384      384
Impacted Files Coverage Δ
module/apmgoredisv8/hook.go 100.00% <100.00%> (ø)
profiling.go 78.12% <0.00%> (+6.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95e54b2...8f54a18. Read the comment docs.

@axw axw merged commit c17563e into elastic:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axw axw axw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@idealism-xxm @apmmachine @axw @codecov-commenter