support pgx v4 driver

[Deepak13245]

No description provided.

[apmmachine]

💚 Build Succeeded

Expand to view the summary

Build stats

• Build Cause: [Pull request #831 updated]

• Start Time: 2020-10-07T05:41:34.186+0000

• Duration: 23 min 19 sec

Test stats 🧪

Test	Results
Failed	0
Passed	7545
Skipped	185
Total	7730

[axw]

Very nice, thank you! We just need to maintain API compatibility (see comment about apmpq.ParseDSN), otherwise this is good to merge.

[axw]

jenkins run the tests please

[axw]

A couple more small things, otherwise LGTM.

[axw]

internal/pgutil will need to be moved to module/apmsql/internal/pgutil, otherwise go.elastic.co/apm has a dependency on apmsql which we do not want.

[codecov-io]

Codecov Report

Merging #831 into master will increase coverage by 0.00%.
The diff coverage is 76.85%.

@@           Coverage Diff           @@
##           master     #831   +/-   ##
=======================================
  Coverage   83.65%   83.65%           
=======================================
  Files         136      138    +2     
  Lines        7823     7827    +4     
=======================================
+ Hits         6544     6548    +4     
  Misses        870      870           
  Partials      409      409           

Impacted Files	Coverage Δ
module/apmsql/internal/pgutil/parser.go	75.96% <75.96%> (ø)
internal/sqlutil/drivername.go	100.00% <100.00%> (ø)
module/apmsql/pgxv4/init.go	100.00% <100.00%> (ø)
module/apmsql/pq/parser.go	100.00% <100.00%> (+24.03%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b847bd...0226a5f. Read the comment docs.

[axw]

Nice work, thanks very much @Deepak13245!