Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make internal/apmgodog its own module #899

Merged
merged 1 commit into from
Feb 17, 2021
Merged

Conversation

axw
Copy link
Member

@axw axw commented Feb 16, 2021

Move feature test-related code to its own module, so we can add dependencies on instrumentation modules. This is tidier anyway, since it means godog can be removed from the main go.mod.

This is required for some changes needed to get #898 passing.

Move feature test-related code to its own module,
so we can add dependencies on instrumentation modules.
This is tidier anyway, since it means godog can be
removed from the main go.mod.
@codecov-io
Copy link

Codecov Report

Merging #899 (19a900e) into master (ba58cd6) will increase coverage by 0.19%.
The diff coverage is 91.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #899      +/-   ##
==========================================
+ Coverage   83.70%   83.89%   +0.19%     
==========================================
  Files         142      140       -2     
  Lines        7934     7868      -66     
==========================================
- Hits         6641     6601      -40     
+ Misses        885      871      -14     
+ Partials      408      396      -12     
Impacted Files Coverage Δ
modelwriter.go 96.62% <ø> (-0.12%) ⬇️
tracer.go 89.04% <50.00%> (-0.02%) ⬇️
config.go 72.29% <100.00%> (+1.12%) ⬆️
context.go 94.84% <100.00%> (+0.28%) ⬆️
error.go 95.18% <100.00%> (+0.01%) ⬆️
module/apmecho/middleware.go 88.76% <100.00%> (+0.12%) ⬆️
module/apmgin/middleware.go 86.76% <100.00%> (+0.19%) ⬆️
module/apmgorilla/middleware.go 83.78% <100.00%> (+0.45%) ⬆️
module/apmhttp/handler.go 78.90% <100.00%> (+0.16%) ⬆️
module/apmhttp/ignorer.go 55.55% <100.00%> (+5.55%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98ddd88...19a900e. Read the comment docs.

@apmmachine
Copy link
Contributor

apmmachine commented Feb 16, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Branch indexing

  • Start Time: 2021-02-16T17:20:23.606+0000

  • Duration: 28 min 39 sec

  • Commit: 19a900e

Test stats 🧪

Test Results
Failed 0
Passed 7670
Skipped 188
Total 7858

Trends 🧪

Image of Build Times

Image of Tests

@axw axw marked this pull request as ready for review February 16, 2021 12:03
@axw axw requested a review from a team February 16, 2021 12:03
@axw axw merged commit e468260 into elastic:master Feb 17, 2021
@axw axw deleted the apmgodog-module branch February 17, 2021 01:57
stuartnelson3 pushed a commit that referenced this pull request Jul 30, 2021
Move feature test-related code to its own module,
so we can add dependencies on instrumentation modules.
This is tidier anyway, since it means godog can be
removed from the main go.mod.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants