Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add Go 1.14-1.16 to matrix #903

Merged
merged 3 commits into from
Feb 17, 2021
Merged

Conversation

axw
Copy link
Member

@axw axw commented Feb 17, 2021

Add the latest patch release of Go versions 1.14 through 1.16 to the test matrix. Tidy up go.sum files to stop CI failing on 1.16.

@apmmachine
Copy link
Contributor

apmmachine commented Feb 17, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: axw commented: jenkins run the tests please

  • Start Time: 2021-02-17T07:56:36.034+0000

  • Duration: 26 min 30 sec

  • Commit: 6ca39da

Test stats 🧪

Test Results
Failed 0
Passed 9934
Skipped 266
Total 10200

Trends 🧪

Image of Build Times

Image of Tests

@axw axw marked this pull request as draft February 17, 2021 06:12
axw added 2 commits February 17, 2021 14:16
Introduce tools.go to track dependency on build tools
like go-licenser. This is needed to ensure they have
an entry in go.sum.
Make sure go.sum files are up to date, to prevent
failures on Go 1.16.
@axw axw force-pushed the goversions-tidy-go-sum branch from 7c42149 to 6ca39da Compare February 17, 2021 06:17
@axw axw marked this pull request as ready for review February 17, 2021 06:44
@axw axw requested a review from a team February 17, 2021 06:44
@axw
Copy link
Member Author

axw commented Feb 17, 2021

pretty sure that integration tests will be resolved with elastic/apm-integration-testing#1061, I'll rerun after that lands.

@axw
Copy link
Member Author

axw commented Feb 17, 2021

jenkins run the tests please

@axw axw merged commit 400bf3d into elastic:master Feb 17, 2021
@axw axw deleted the goversions-tidy-go-sum branch February 17, 2021 08:38
stuartnelson3 pushed a commit that referenced this pull request Jul 30, 2021
* ci: add Go 1.14 and 1.15 to test matrix

* Introduce tools.go

Introduce tools.go to track dependency on build tools
like go-licenser. This is needed to ensure they have
an entry in go.sum.

* go mod tidy

Make sure go.sum files are up to date, to prevent
failures on Go 1.16.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants