Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic logger ecs reconfig #1261

Merged
merged 80 commits into from
Mar 17, 2021

Conversation

eyalkoren
Copy link
Contributor

@eyalkoren eyalkoren commented Jun 30, 2020

What does this PR do?

Checklist

  • This is an enhancement of existing features, or a new feature in existing plugins
    • I have updated CHANGELOG.asciidoc
    • I have added tests that prove my fix is effective or that my feature works
    • Added an API method or config option? Document in which version this will be introduced
    • I have made corresponding changes to the documentation
  • This is a bugfix
  • This is a new plugin
  • This is something else

@apmmachine
Copy link
Contributor

apmmachine commented Jun 30, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Started by user eyalkoren

  • Start Time: 2021-03-17T17:55:36.993+0000

  • Duration: 50 min 19 sec

  • Commit: d4622aa

Test stats 🧪

Test Results
Failed 0
Passed 1883
Skipped 15
Total 1898

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1883
Skipped 15
Total 1898

Copy link
Member

@felixbarny felixbarny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is not ready yet but I was too curious about this PR :)

Copy link
Member

@felixbarny felixbarny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might have to refine how the service.name is computed but let's not block this PR on that. It's an experimental feature anyway.

@eyalkoren eyalkoren merged commit 7f62bf1 into elastic:master Mar 17, 2021
@eyalkoren eyalkoren deleted the dynamic-logger-ecs-reconfig branch March 17, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-java logging application logging instrumentation and support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants