Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vertx3 tests #3044

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Fix vertx3 tests #3044

merged 2 commits into from
Mar 2, 2023

Conversation

SylvainJuge
Copy link
Member

@SylvainJuge SylvainJuge commented Mar 2, 2023

What does this PR do?

Fixes the vertx3 tests failures

We have a floating dependency version on vertx-junit, and the latest 4.x version is not compatible anymore with 3.x.
As this is only for testing, sticking to an older version for vertx3 should be fine for now.

Checklist

@apmmachine
Copy link
Contributor

apmmachine commented Mar 2, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview previewSnapshots

Expand to view the summary

Build stats

  • Start Time: 2023-03-02T10:18:45.388+0000

  • Duration: 60 min 23 sec

Test stats 🧪

Test Results
Failed 0
Passed 3553
Skipped 121
Total 3674

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run windows tests : Build & tests on windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@SylvainJuge SylvainJuge marked this pull request as ready for review March 2, 2023 10:04
@github-actions
Copy link

github-actions bot commented Mar 2, 2023

/test

@SylvainJuge SylvainJuge enabled auto-merge (squash) March 2, 2023 10:15
@SylvainJuge SylvainJuge merged commit c8e224e into elastic:main Mar 2, 2023
@SylvainJuge SylvainJuge deleted the fix-vertx3-tests branch March 2, 2023 12:12
@SylvainJuge SylvainJuge mentioned this pull request Apr 12, 2023
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants