Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove support for ELASTIC_APM_KUBERNETES_* envvars #2661

Closed
trentm opened this issue Apr 27, 2022 · 1 comment
Closed

remove support for ELASTIC_APM_KUBERNETES_* envvars #2661

trentm opened this issue Apr 27, 2022 · 1 comment
Assignees
@trentm
Labels
agent-nodejs Make available for APM Agents project planning.
Milestone
next-major

Comments

@trentm
Copy link
Member

trentm commented Apr 27, 2022

We should consider deprecating and removing the old environment variables in the next major.

from the description of #1041

Way back when elastic/apm#21 was implemented for the Node.js APM agent, the envvar configuration support accidentally used the ELASTIC_APM_ prefix for the new Kubernetes environment variable support:

KUBERNETES_NODE_NAME | system.kubernetes.node.name
KUBERNETES_POD_NAME | system.kubernetes.pod.name
KUBERNETES_NAMESPACE | system.kubernetes.namespace
KUBERNETES_POD_UID | system.kubernetes.pod.uid

Then in #1041 support was added for the unprefixed envvar names, as originally intended. At the time the prefixed-envvars were kept for backward compat.
@trentm trentm added this to the next-major milestone Apr 27, 2022
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Apr 27, 2022
trentm added a commit that referenced this issue Aug 1, 2023
@trentm
chore!: drop ELASTIC_APM_KUBERNETES_* envvars, bump min to node v14.5.0
6a5571c 
This starts an "Upgrade to 4.x" guide.

Bumping the min Node.js to 14.5.0 means we will be able to rely on
AsyncLocalStorage support.

Closes: #2661
Refs: #3529
@trentm trentm mentioned this issue Aug 1, 2023
Merged
@trentm trentm self-assigned this Aug 1, 2023
trentm added a commit that referenced this issue Aug 2, 2023
@trentm
chore!: drop ELASTIC_APM_KUBERNETES_* envvars, bump min to node v14.5…
09202a1 
….0 (#3536)

This starts an "Upgrade to 4.x" guide.

Bumping the min Node.js to 14.5.0 means we will be able to rely on
AsyncLocalStorage support.

Closes: #2661
Refs: #3529
@trentm
Copy link
Member Author

trentm commented Aug 2, 2023

Closed by #3536 on the "dev/4.x" branch, which will become the 4.x active branch soonish.

@trentm trentm closed this as completed Aug 2, 2023
trentm added a commit that referenced this issue Sep 1, 2023
@trentm
4.x (#3528)
c6cdaf9 
feat!: the start of v4.x

Significant and breaking changes:
- Min supported Node.js is now 14.5.0 (up from 8.6).
- Drop support for the obsolete "patch" context manager, i.e. the
  `contextManager: "patch"` config option. This was a limited async context
  management that predated the preferred `AsyncLocalStorage` core Node.js
  mechanism for context tracking. (#3529)
- Config vars:
    - Remove `logUncaughtExceptions` config option, if the agent's
      `uncaughtException` handler is active it now *always* logs the error to
      the console. (#2412)
    - Remove `filterHttpHeaders` config option, see `sanitizeFieldNames`
      instead. (#3332)
    - Remove long deprecate `ELASTIC_APM_KUBERNETES_*` envvars, use
      `KUBERNETES_*` instead. (#2661)
    - The `useElasticTraceparentHeader` config option now defaults to `false`.
      This means the `elastic-apm-traceparent` HTTP header is now no longer
      sent by default. (#3555)
    - Drop erroneous `ELASTIC_SANITIZE_FIELD_NAMES` and
      `ELASTIC_IGNORE_MESSAGE_QUEUES` config envvars.
- Instrumentations:
    - Drop instrumentation for old `hapi`, the current `@hapi/hapi` is still
      instrumented. (#2691)
- APIs:
    - Ignore a `timer` option passed to `startTransaction()` and `startSpan()`
      APIs. (#2990)
    - Remove the deprecated `span.toString()` and `transaction.toString()` APIs.
      (#2348)
    - Change `apm.startTransaction()` API to return a noop transaction instead
      of null when the agent is not started. (#2429)
    - Remove `transaction.subtype` and `transaction.action` properties from the
      API. This also impacts <<apm-start-transaction>> and
      `transaction.setType(...)`, both of which now no longer accept `subtype`
      and `action` parameters. (#3557)
fpm-peter pushed a commit to fpm-git/apm-agent-nodejs that referenced this issue Aug 20, 2024
@trentm @fpm-peter
4.x (elastic#3528)
52924ec 
feat!: the start of v4.x

Significant and breaking changes:
- Min supported Node.js is now 14.5.0 (up from 8.6).
- Drop support for the obsolete "patch" context manager, i.e. the
  `contextManager: "patch"` config option. This was a limited async context
  management that predated the preferred `AsyncLocalStorage` core Node.js
  mechanism for context tracking. (elastic#3529)
- Config vars:
    - Remove `logUncaughtExceptions` config option, if the agent's
      `uncaughtException` handler is active it now *always* logs the error to
      the console. (elastic#2412)
    - Remove `filterHttpHeaders` config option, see `sanitizeFieldNames`
      instead. (elastic#3332)
    - Remove long deprecate `ELASTIC_APM_KUBERNETES_*` envvars, use
      `KUBERNETES_*` instead. (elastic#2661)
    - The `useElasticTraceparentHeader` config option now defaults to `false`.
      This means the `elastic-apm-traceparent` HTTP header is now no longer
      sent by default. (elastic#3555)
    - Drop erroneous `ELASTIC_SANITIZE_FIELD_NAMES` and
      `ELASTIC_IGNORE_MESSAGE_QUEUES` config envvars.
- Instrumentations:
    - Drop instrumentation for old `hapi`, the current `@hapi/hapi` is still
      instrumented. (elastic#2691)
- APIs:
    - Ignore a `timer` option passed to `startTransaction()` and `startSpan()`
      APIs. (elastic#2990)
    - Remove the deprecated `span.toString()` and `transaction.toString()` APIs.
      (elastic#2348)
    - Change `apm.startTransaction()` API to return a noop transaction instead
      of null when the agent is not started. (elastic#2429)
    - Remove `transaction.subtype` and `transaction.action` properties from the
      API. This also impacts <<apm-start-transaction>> and
      `transaction.setType(...)`, both of which now no longer accept `subtype`
      and `action` parameters. (elastic#3557)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trentm trentm

Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Milestone
next-major
Development

No branches or pull requests
1 participant
@trentm