Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Status for Node 10 ? #448

Closed
danieljuhl opened this issue Jul 17, 2018 · 1 comment · Fixed by #449
Closed

Status for Node 10 ? #448

danieljuhl opened this issue Jul 17, 2018 · 1 comment · Fixed by #449
Assignees
@watson
Labels
docs

Comments

@danieljuhl
Copy link
Contributor

danieljuhl commented Jul 17, 2018 •
edited by alvarolobato
Loading

The Compatibility Overview says that node v10.x is buggy and not supported. There is a reference to an issue in the node repo, but that issues seems to be closed.

Are we tracking it?, and is node v10.x still not supported?
@watson
Copy link
Contributor

watson commented Jul 17, 2018

Good call. The issue was fixed in Node and released in v10.4.0. So you should be all good to use this module with Node 10. I'll make a PR to remove warning from the docs.

watson added a commit to watson/apm-agent-nodejs that referenced this issue Jul 17, 2018
@watson
docs: remove reference to Node 10 incompatibility
ea657c8 
The bug in V8 that meant we couldn't instrument Node 10 was fixed and
Node 10.4.0 shipped with a newer version of V8.

This is the original bug report in Node:
nodejs/node#20516

This is the PR that fixed it in Node:
nodejs/node#19989

Closes elastic#448
@watson watson mentioned this issue Jul 17, 2018
Merged
@watson watson self-assigned this Jul 17, 2018
@watson watson added the docs label Jul 17, 2018
watson added a commit that referenced this issue Jul 18, 2018
@watson
docs: remove reference to Node 10 incompatibility (#449)
588df54 
The bug in V8 that meant we couldn't instrument Node 10 was fixed and
Node 10.4.0 shipped with a newer version of V8.

This is the original bug report in Node:
nodejs/node#20516

This is the PR that fixed it in Node:
nodejs/node#19989

Closes #448
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@watson watson

Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: remove reference to Node 10 incompatibility watson/apm-agent-nodejs
3 participants
@watson @danieljuhl @alvarolobato