-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
instrumentation of @aws-sdk/client-dynamodb #3486
Conversation
* Slurp everything from the given ReadableStream and return the content, | ||
* converted to a string. | ||
*/ | ||
async function slurpStream (stream) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for reviewer: function copied here to be used in use-client-*
files. Current dynamodb
tests don't make use of it, yet.
Ci failing due to a problem in environment. Apparently we're using a newer version of
This does not make much sense with the previous message shown by the GH action
Link to the error: https://github.com/elastic/apm-agent-nodejs/actions/runs/5575905829/jobs/10187134325 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/test tav @aws-sdk/client-dynamodb
Mystery solved, |
Sorry for your merge pain. Might be easiest to do a merge like this:
|
Closing this PR to prepare this instrumentation for next major release |
PR to add instrumentation to
@aws-sdk/client-dynamodb
package. Since in SDK v3 all clients are similar I took a same approach done in S3 intrumentationfinalizeRequest
middleware is not executedCloses #2958
Checklist