Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] gRPC support #645

Closed
xiaowuyz opened this issue Nov 22, 2019 · 8 comments · Fixed by #1703
Closed

[Feature] gRPC support #645

xiaowuyz opened this issue Nov 22, 2019 · 8 comments · Fixed by #1703
Assignees
@beniwohli
Labels
agent-python feature instrumentation
Milestone
8.7

Comments

@xiaowuyz
Copy link

xiaowuyz commented Nov 22, 2019 •
edited by basepi
Loading

APM support for gRPC would be excellent. We can likely implement this support via gRPC interceptors.
@xiaowuyz xiaowuyz changed the title How can I support amp on GRPC How can I support apm on GRPC Nov 22, 2019
@beniwohli
Copy link
Contributor

Hi @xiaowuyz

The Python agent currently doesn't support grpc. We do plan to add support some time in the coming months.

@basepi basepi changed the title How can I support apm on GRPC [Feature] gRPC support Nov 22, 2019
@basepi basepi added the feature label Nov 22, 2019
@basepi
Copy link
Contributor

basepi commented Nov 22, 2019

I took the liberty of editing your issue title/text so that we can track gRPC implementation here.

@basepi basepi self-assigned this Apr 22, 2020
@basepi basepi added this to the 7.8 milestone Apr 22, 2020
@RyanKung RyanKung mentioned this issue Jun 16, 2020
Closed
@basepi basepi removed their assignment Jun 18, 2020
@basepi basepi modified the milestones: 7.8, 7.9 Jun 18, 2020
@basepi basepi removed this from the 7.9 milestone Aug 26, 2020
@Zioyi Zioyi mentioned this issue Jun 28, 2021
Closed
@julianogv
Copy link

@basepi Any idea on when we will have grpc support for python client?

@basepi
Copy link
Contributor

basepi commented May 9, 2022

No clear idea yet, but I've added it to our roadmap discussions.

@estolfo estolfo added this to the 8.6 milestone Sep 28, 2022
@smitp33
Copy link

smitp33 commented Nov 4, 2022

Hi, be really interesting to know how this is progressing on your roadmap. We are a platform that is heavily invested in elastic APM and see real value from it. Our only current gap is the platform traffic that is GRPC based so having this capability would be gold dust for us ;)

@basepi
Copy link
Contributor

basepi commented Nov 4, 2022

Hey @smitp33! I'm pretty sure @beniwohli is working on this right now, so hopefully we'll have some good news for you soon!

@smitp33
Copy link

smitp33 commented Nov 8, 2022

That is great news @basepi. If we can help any in terms of real world testing please do let us know.

@estolfo estolfo removed this from the 8.6 milestone Nov 30, 2022
@estolfo estolfo added this to the 8.7 milestone Nov 30, 2022
@basepi basepi mentioned this issue Dec 5, 2022
Merged
@basepi
Copy link
Contributor

basepi commented Dec 5, 2022

If anyone is still willing to test, we have an open PR! #1703

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beniwohli beniwohli

Labels
agent-python feature instrumentation
Projects
None yet
Milestone
8.7
Development

Successfully merging a pull request may close this issue.

GRPC Instrumentation beniwohli/apm-agent-python
7 participants
@beniwohli @estolfo @basepi @AlexanderWert @julianogv @smitp33 @xiaowuyz