Support grpc Server & Client (WIP) #862
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 16, 2020
| def request_started(self, handler_call_details): | ||
| meta_data = handler_call_details.invocation_metadata[0]._asdict() | ||
| trace_parent = TraceParent.from_headers(meta_data) | ||
| method = handler_call_details.method |
There was a problem hiding this comment.
local variable 'method' is assigned to but never used
| should be a callable object that follow: | ||
| Callable[str] -> bool | ||
| """ | ||
| def __init__(self, client=None, client_cls=Client, logging=False, config={}, **defaults): |
There was a problem hiding this comment.
Do not use mutable data structures for argument defaults. They are created during function definition time. All calls to the function reuse this one instance of that data structure, persisting changes between them.
| from elasticapm.contrib.flask.utils import get_data_from_request, get_data_from_response | ||
| from elasticapm.handlers.logging import LoggingHandler | ||
| from elasticapm.traces import execution_context | ||
| from elasticapm.utils import build_name_with_http_method_prefix |
There was a problem hiding this comment.
'elasticapm.utils.build_name_with_http_method_prefix' imported but unused
| import elasticapm.instrumentation.control | ||
| from elasticapm.base import Client | ||
| from elasticapm.conf import constants, setup_logging | ||
| from elasticapm.contrib.flask.utils import get_data_from_request, get_data_from_response |
There was a problem hiding this comment.
'elasticapm.contrib.flask.utils.get_data_from_request' imported but unused
'elasticapm.contrib.flask.utils.get_data_from_response' imported but unused
| import elasticapm | ||
| import elasticapm.instrumentation.control | ||
| from elasticapm.base import Client | ||
| from elasticapm.conf import constants, setup_logging |
There was a problem hiding this comment.
'elasticapm.conf.constants' imported but unused
❕ Build Aborted
Expand to view the summary
Build stats
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
houndci-bot
reviewed
Jun 22, 2020
| try: | ||
| return self.with_transaction(handler_call_details, continuation) | ||
| except Exception: | ||
| logger.error("Exception during handle transaction", exc_info) |
| logger.error("Exception durinng handle request", exc_info=True) | ||
|
|
||
|
|
||
| def request_finished(self, result): |
houndci-bot
reviewed
Jun 27, 2020
| ] | ||
|
|
||
| def call(self, module, method, wrapped, instance, args, kwargs): | ||
| channel = instance |
There was a problem hiding this comment.
local variable 'channel' is assigned to but never used
|
Hi, I am care about this PR, how is going?[excited] |
|
I am also very interested in this PR. Is there anything we can do to get the ball rolling again @RyanKung @beniwohli |
|
Hi, when will this RP merge? |
|
Tried the code from this PR. My findings so far:
Asyncio and headers are easy to fix, but im not sure about the future. |
|
Sorry guys, I don't have enough time to finish this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Emm, Support grpc server.
Related issues
#645