Add auto_ecs_logging config
#1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
beniwohli
pushed a commit
to beniwohli/apm-agent-python
that referenced
this pull request
Sep 14, 2021
* Implement auto_ecs_logging config and docs * Add a test for auto_ecs_logging * Changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Adds a new config value, called
auto_ecs_logging, which defaults to False. If the user sets this value to True (and hasecs_logginginstalled), we will do two things:setFormatter(ecs_logging.StdlibFormatter())on each of the handlers on the root loggerstructlog(if installed) toecs_logging.StructlogFormatter().I also documented the new setting and added a test.
Related issues
Closes #1006