Add aioredis instrumentation

[Sparkycz]

What does this pull request do?

Adds aioredis instrumentation

Related issues

closes #1080

[houndci-bot]

Some files could not be reviewed due to errors:

Traceback (most recent call last):

Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 5, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

[houndci-bot]

Some files could not be reviewed due to errors:

Traceback (most recent call last):

Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 5, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

[houndci-bot]

Some files could not be reviewed due to errors:

Traceback (most recent call last):

Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 5, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

[apmmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Build Cause: Started by user Benjamin Wohlwend

• Start Time: 2021-04-29T13:28:39.399+0000

• Duration: 22 min 23 sec

• Commit: d941f4e

Test stats 🧪

Test	Results
Failed	0
Passed	9216
Skipped	8270
Total	17486

Trends 🧪

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test	Results
Failed	0
Passed	9216
Skipped	8270
Total	17486

[Sparkycz]

I checked the failed jobs and I think these are beyond my changes. Please, anyone, check it out and help me to solve it.

[beniwohli]

@Sparkycz awesome stuff, thanks a lot!

The original test failure was a problem on one of our Windows test machines, it went away when I restarted the test run.

The weird @houndci-bot failures seem to be related to houndci/hound#1839. Nothing we can do about that right now...

I'll do a more in-depth review later this week.

[houndci-bot]

Some files could not be reviewed due to errors:

Traceback (most recent call last):

Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 5, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

[houndci-bot]

Some files could not be reviewed due to errors:

Traceback (most recent call last):

Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 5, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

[houndci-bot]

Some files could not be reviewed due to errors:

Traceback (most recent call last):

Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 5, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

[ajay1mg]

Thank you @Sparkycz, I checked your code and now wondering how fast you were in adding the support for this. Could you help me understand how you came up with this piece of code?

Going forward I would love to contribute to this since I may have other requirements with my APM integration

[beniwohli]

@Sparkycz Great work! I took the liberty to push some needed boilerplate code to ensure your tests are run in our CI test matrix.

I noticed that the maintainers of aioredis are getting ready to release version 2.0.0 of the library, which from the sound of it, changes more or less completely how the API of the library works. We'll probably need to adapt some things. Would you like to do that or should I take over that part?

[Sparkycz]

@Sparkycz Great work! I took the liberty to push some needed boilerplate code to ensure your tests are run in our CI test matrix.

I noticed that the maintainers of aioredis are getting ready to release version 2.0.0 of the library, which from the sound of it, changes more or less completely how the API of the library works. We'll probably need to adapt some things. Would you like to do that or should I take over that part?

Thanks for the boilerplate code I didn't know It's needed as well..

I'd wait for the stable release and I'll try doing that.. You imagine having two versions of the instrumentation 754731f#diff-523e55d3048a9bdd660f01803427652e28fb5a0610ad41f9c6a98575e83ef67fR22 , don't you?

[Sparkycz]

Hello @beniwohli, please, what is the PR waiting for? :-)

[Sparkycz]

@basepi Could you unfreeze the PR please?

[beniwohli]

@Sparkycz sorry about the wait here, we do have a lot of other work on our plate, so I didn't have a chance to merge the PR yet. I'll get it merged today and do a release soon.