-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aioredis instrumentation #1082
Add aioredis instrumentation #1082
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last): File "/home/linters/.local/bin/flake8", line 5, in from flake8.main.cli import main ModuleNotFoundError: No module named 'flake8'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last): File "/home/linters/.local/bin/flake8", line 5, in from flake8.main.cli import main ModuleNotFoundError: No module named 'flake8'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last): File "/home/linters/.local/bin/flake8", line 5, in from flake8.main.cli import main ModuleNotFoundError: No module named 'flake8'
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
I checked the failed jobs and I think these are beyond my changes. Please, anyone, check it out and help me to solve it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sparkycz awesome stuff, thanks a lot!
The original test failure was a problem on one of our Windows test machines, it went away when I restarted the test run.
The weird @houndci-bot failures seem to be related to houndci/hound#1839. Nothing we can do about that right now...
I'll do a more in-depth review later this week.
Co-authored-by: Benjamin Wohlwend <bw@piquadrat.ch>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last): File "/home/linters/.local/bin/flake8", line 5, in from flake8.main.cli import main ModuleNotFoundError: No module named 'flake8'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last): File "/home/linters/.local/bin/flake8", line 5, in from flake8.main.cli import main ModuleNotFoundError: No module named 'flake8'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last): File "/home/linters/.local/bin/flake8", line 5, in from flake8.main.cli import main ModuleNotFoundError: No module named 'flake8'
Thank you @Sparkycz, I checked your code and now wondering how fast you were in adding the support for this. Could you help me understand how you came up with this piece of code? Going forward I would love to contribute to this since I may have other requirements with my APM integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sparkycz Great work! I took the liberty to push some needed boilerplate code to ensure your tests are run in our CI test matrix.
I noticed that the maintainers of aioredis are getting ready to release version 2.0.0 of the library, which from the sound of it, changes more or less completely how the API of the library works. We'll probably need to adapt some things. Would you like to do that or should I take over that part?
Thanks for the boilerplate code I didn't know It's needed as well.. I'd wait for the stable release and I'll try doing that.. You imagine having two versions of the instrumentation 754731f#diff-523e55d3048a9bdd660f01803427652e28fb5a0610ad41f9c6a98575e83ef67fR22 , don't you? |
Hello @beniwohli, please, what is the PR waiting for? :-) |
@basepi Could you unfreeze the PR please? |
@Sparkycz sorry about the wait here, we do have a lot of other work on our plate, so I didn't have a chance to merge the PR yet. I'll get it merged today and do a release soon. |
* Add aioredis instrumentation * fix code formating by black Co-authored-by: Benjamin Wohlwend <bw@piquadrat.ch> * add boilerplate for CI test matrix * Use async_capture_span instead of capture_span in aioredis instrumentation * Blacking.. Co-authored-by: Benjamin Wohlwend <beni@elastic.co>
What does this pull request do?
Adds aioredis instrumentation
Related issues
closes #1080