-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that metrics are flushed before shutting down #1139
Conversation
To ensure that the flushed metrics are actually sent, we need to make sure that the transport thread is shut down last.
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Test errorsExpand to view the tests failures
|
Test | Results |
---|---|
Failed | 2 |
Passed | 9428 |
Skipped | 8443 |
Total | 17873 |
Genuine test errors
💔 There are test failures but not known flaky tests, most likely a genuine test failure.
- Name:
Initializing / Test / Python-python-3.8-4 / test_publish_subscribe – tests.instrumentation.asyncio_tests.aioredis_tests
- Name:
Initializing / Test / Python-python-3.9-3 / test_publish_subscribe – tests.instrumentation.asyncio_tests.aioredis_tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
/cc @stj — this will help our use of custom metrics
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Steps errorsExpand to view the steps failures
|
Test | Results |
---|---|
Failed | 0 |
Passed | 8866 |
Skipped | 8721 |
Total | 17587 |
* Ensure that metrics are flushed before shutting down To ensure that the flushed metrics are actually sent, we need to make sure that the transport thread is shut down last. * use a variable name that doesn't clash with the thread priority concept
To ensure that the flushed metrics are actually sent, we need
to make sure that the transport thread is shut down last.
See also elastic/apm#444