Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aiofiles to starlette-0.14 requirements file #1189

Merged
merged 2 commits into from
Jul 13, 2021

Conversation

beniwohli
Copy link
Contributor

What does this pull request do?

The requirement went forgotten in the 0.14 requirements file, it's there for the other versions.

@apmmachine
Copy link
Contributor

apmmachine commented Jul 12, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-07-12T15:14:39.654+0000

  • Duration: 27 min 40 sec

  • Commit: 7a74a9b

Test stats 🧪

Test Results
Failed 0
Passed 9507
Skipped 8604
Total 18111

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 9507
Skipped 8604
Total 18111

@basepi
Copy link
Contributor

basepi commented Jul 12, 2021

This one was my fault. I rewrote the requirements files before merging #1137 and so missed it. Thanks for grabbing this!

@beniwohli beniwohli merged commit 02acd9b into elastic:master Jul 13, 2021
@beniwohli beniwohli deleted the starlette-014-aiofiles branch July 13, 2021 07:23
beniwohli added a commit to beniwohli/apm-agent-python that referenced this pull request Sep 14, 2021
Co-authored-by: Colton Myers <colton.myers@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants