Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in lambda support with service_name overrides #1493

Merged
merged 4 commits into from
Mar 23, 2022

Conversation

basepi
Copy link
Contributor

@basepi basepi commented Mar 22, 2022

What does this pull request do?

The JIT metadata overrides in our AWS lambda support had the side effect of not allowing for a custom-configured service_name. This fixes that issue and adds a test.

Related issues

Closes #1486

@basepi basepi requested a review from beniwohli March 22, 2022 16:57
@apmmachine
Copy link
Contributor

apmmachine commented Mar 22, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-22T17:49:12.555+0000

  • Duration: 21 min 26 sec

Test stats 🧪

Test Results
Failed 0
Passed 4842
Skipped 3207
Total 8049

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /test linters : Run the Python linters only.

  • /test full : Run the full matrix of tests.

  • /test benchmark : Run the APM Agent Python benchmarks tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@beniwohli beniwohli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@basepi basepi merged commit 9064513 into elastic:main Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ELASTIC_APM_SERVICE_NAME env var for Python Lambda not working
3 participants