-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Celery contrib: read custom parent span id from the task headers #1500
Merged
basepi
merged 8 commits into
elastic:main
from
namoshizun:celery-allow-cutom-parent-span
Mar 29, 2022
Merged
Celery contrib: read custom parent span id from the task headers #1500
basepi
merged 8 commits into
elastic:main
from
namoshizun:celery-allow-cutom-parent-span
Mar 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 CLA has been signed |
github-actions
bot
added
agent-python
community
Issues opened by the community
triage
Issues awaiting triage
labels
Mar 26, 2022
…ying the inner headers
namoshizun
commented
Mar 27, 2022
basepi
approved these changes
Mar 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! We're fixing a CI failure caused by upstream changes in another library, and then we should be able to get the tests run here and merge this.
Can you add a note to the CHANGELOG?
/test |
run elasticsearch-ci/docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
In a complex Celery workflow, tasks might be invoked in a chain like this:
In such setting, because the current Celery instrument only propagates the first caller's traceparent, all downstream tasks share the same traceparent from A. This might be undesirable if every task should be regarded as a subtask of its caller.
For instance, "submit_task_for_computation" initiates "do_heavy_lifting" and waits for completion so that it can immediately rollback a database transaction if the job failed. But instead of correlate do_heavy_lifting with submit_task_for_computation, current instrument produces the following trace:
Whereas we actually hope for this:
This PR is to allow a caller task to set the receiver task's parent span by passing a
parent_span_id
in the Celery headers.I have prepared this snippet as a demo.