Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add public API for span links #1562

Merged
merged 3 commits into from
Jun 2, 2022
Merged

Conversation

beniwohli
Copy link
Contributor

@beniwohli beniwohli commented Jun 1, 2022

What does this pull request do?

  • implement API for providing span links to transactions and spans
  • add span link support to OTel Bridge

Related issues

closes #1541

@apmmachine
Copy link
Contributor

apmmachine commented Jun 1, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-02T06:37:32.279+0000

  • Duration: 34 min 46 sec

Test stats 🧪

Test Results
Failed 0
Passed 4870
Skipped 3455
Total 8325

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /test linters : Run the Python linters only.

  • /test full : Run the full matrix of tests.

  • /test benchmark : Run the APM Agent Python benchmarks tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@apmmachine
Copy link
Contributor

apmmachine commented Jun 1, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (68/68) 💚
Files 100.0% (227/227) 💚
Classes 100.0% (227/227) 💚
Lines 89.513% (17055/19053) 👍 0.064
Conditionals 76.588% (3111/4062) 👍 0.157

@beniwohli beniwohli requested a review from basepi June 1, 2022 13:47
Copy link
Contributor

@basepi basepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I originally thought there would need to be changes in opentelemetry/span.py but I double-checked and we're good. Span is a pretty loose wrapper so it doesn't have references to the span links. 👍

@beniwohli beniwohli enabled auto-merge (squash) June 2, 2022 06:37
@beniwohli beniwohli merged commit c638501 into elastic:main Jun 2, 2022
@beniwohli beniwohli deleted the span-link-api branch June 2, 2022 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[META 643] Implement Span Links API
3 participants