Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement trace_continuation_strategy #1564

Merged
merged 4 commits into from
Jun 7, 2022
Merged

implement trace_continuation_strategy #1564

merged 4 commits into from
Jun 7, 2022

Conversation

beniwohli
Copy link
Contributor

What does this pull request do?

Implements https://github.com/elastic/apm/blob/main/specs/agents/trace-continuation.md

Related issues

closes #1472

beniwohli
beniwohli commented Jun 2, 2022
View reviewed changes
docs/configuration.asciidoc
| `ELASTIC_APM_TRACE_CONTINUATION_STRATEGY` | `TRACE_CONTINUATION_STRATEGY` | `continue`
|============

This option allows some control on how the APM agent handles W3C trace-context headers on incoming requests.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole section is lifted from the nodejs agent docs

@beniwohli beniwohli requested a review from basepi June 2, 2022 08:17
@apmmachine
Copy link
Contributor

apmmachine commented Jun 2, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-07T12:53:08.719+0000

  • Duration: 33 min 11 sec

Test stats 🧪

Test Results
Failed 0
Passed 4888
Skipped 3455
Total 8343

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /test linters : Run the Python linters only.

  • /test full : Run the full matrix of tests.

  • /test benchmark : Run the APM Agent Python benchmarks tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@apmmachine
Copy link
Contributor

apmmachine commented Jun 2, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (68/68) 💚
Files 100.0% (227/227) 💚
Classes 100.0% (227/227) 💚
Lines 89.567% (17152/19150) 👍 0.025
Conditionals 76.634% (3119/4070) 👍 0.023

@beniwohli beniwohli enabled auto-merge (squash) June 7, 2022 12:52
@beniwohli beniwohli merged commit 986c868 into elastic:main Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basepi basepi basepi approved these changes

Assignees
No one assigned
Labels
agent-python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[META 604] Implement trace_continuation_strategy
3 participants
@beniwohli @apmmachine @basepi