Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix errorhandling of LoggingHandler.emit #1568

Merged
merged 2 commits into from
Jun 9, 2022

Conversation

beniwohli
Copy link
Contributor

When a LogRecord has a non-string as the .msg attribute,
just trying to concatenate it with "\n" leads to an error.

A similar problem also existed in the LogBook handler.

This error was first reported in #1340, but it wasn't obvious due to a chained exception.

closes #1340

When a LogRecord has a non-string as the `.msg` attribute,
just trying to concatenate it with `"\n"` leads to an error.

A similar problem also existed in the LogBook handler.

closes elastic#1340
@apmmachine
Copy link
Contributor

apmmachine commented Jun 8, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-08T08:48:34.660+0000

  • Duration: 30 min 24 sec

Test stats 🧪

Test Results
Failed 0
Passed 4898
Skipped 3455
Total 8353

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /test linters : Run the Python linters only.

  • /test full : Run the full matrix of tests.

  • /test benchmark : Run the APM Agent Python benchmarks tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@beniwohli beniwohli added this to the 8.4 milestone Jun 8, 2022
@apmmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (68/68) 💚
Files 100.0% (227/227) 💚
Classes 100.0% (227/227) 💚
Lines 89.574% (17165/19163) 👍 0.007
Conditionals 76.632% (3122/4074) 👎 -0.002

@beniwohli beniwohli merged commit f9a4236 into elastic:main Jun 9, 2022
@beniwohli beniwohli deleted the potential-fix-1340 branch June 9, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exception logging an error with a big local variable
3 participants