-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong transaction names in Django 4.0+ #1571
Conversation
🌐 Coverage report
|
@dhalenok awesome, thanks for opening the issue and this PR! The fix looks good. I was wondering why this wasn't caught by our tests, and it turns out we don't have any class based views in out test app. If you like, you could add one, and then test that we get the correct name by copying and modifying this test: apm-agent-python/tests/contrib/django/django_tests.py Lines 732 to 747 in 986c868
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix and test, thanks!
What does this pull request do?
get_name_from_func
to useview_class
attribute when resolving view name.Related issues
closes #1570