Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cast redis ports to int #1591

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Conversation

qeternity
Copy link
Contributor

@qeternity qeternity commented Jul 21, 2022

What does this pull request do?

It appears possible in at least some versions of the python redis libraries (redis-py and aioredis) to end up with ports that are stored as strings, whereas apm-server is expecting an int, which results in parsing issues. This preemptively casts all redis ports to ints before building the destination info.

@github-actions github-actions bot added agent-python community Issues opened by the community triage Issues awaiting triage labels Jul 21, 2022
@apmmachine
Copy link
Contributor

apmmachine commented Jul 21, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-21T18:09:23.489+0000

  • Duration: 28 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 4922
Skipped 3455
Total 8377

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /test linters : Run the Python linters only.

  • /test full : Run the full matrix of tests.

  • /test benchmark : Run the APM Agent Python benchmarks tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@basepi
Copy link
Contributor

basepi commented Jul 21, 2022

/test

Copy link
Contributor

@basepi basepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for adding this.

@apmmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (68/68) 💚
Files 100.0% (227/227) 💚
Classes 100.0% (227/227) 💚
Lines 89.62% (17251/19249) 👍
Conditionals 76.771% (3143/4094) 👍

@basepi
Copy link
Contributor

basepi commented Jul 21, 2022

/test linters

@basepi basepi enabled auto-merge (squash) July 21, 2022 18:19
@basepi basepi merged commit 02ed26d into elastic:main Jul 21, 2022
@qeternity qeternity deleted the cast-redis-ports-to-int branch September 4, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-python community Issues opened by the community triage Issues awaiting triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants