Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly set transaction outcome #1637

Merged
merged 3 commits into from
Sep 19, 2022
Merged

Conversation

LucaWintergerst
Copy link
Contributor

@LucaWintergerst LucaWintergerst commented Sep 16, 2022

What does this pull request do?

properly set transaction outcome for flask instrumentation when an exception occurs

Related issues

Closes #1636

@github-actions github-actions bot added agent-python community Issues opened by the community triage Issues awaiting triage labels Sep 16, 2022
Copy link
Contributor

@basepi basepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see any reason this fix will be problematic. Thank you for tracking this down and fixing it!

@basepi basepi enabled auto-merge (squash) September 19, 2022 18:39
@LucaWintergerst
Copy link
Contributor Author

And thank you for taking a look at this so quickly!

@apmmachine
Copy link
Contributor

apmmachine commented Sep 19, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-19T18:56:37.569+0000

  • Duration: 29 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 4986
Skipped 3338
Total 8324

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /test linters : Run the Python linters only.

  • /test full : Run the full matrix of tests.

  • /test benchmark : Run the APM Agent Python benchmarks tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@apmmachine
Copy link
Contributor

apmmachine commented Sep 19, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (66/66) 💚
Files 100.0% (225/225) 💚
Classes 100.0% (225/225) 💚
Lines 89.808% (17473/19456) 👍 0.001
Conditionals 77.144% (3193/4139) 👍

@basepi
Copy link
Contributor

basepi commented Sep 19, 2022

/test linters

@basepi basepi merged commit a6a81ca into elastic:main Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-python community Issues opened by the community triage Issues awaiting triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flask instrumentation does not capture transaction outcome properly during exception
3 participants