-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use typing.TypeVar on decorators' type hints #1655
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes issue elastic#1654
💚 CLA has been signed |
github-actions
bot
added
agent-python
community
Issues opened by the community
triage
Issues awaiting triage
labels
Sep 30, 2022
🌐 Coverage report
|
basepi
approved these changes
Oct 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you for implementing this!
beniwohli
approved these changes
Oct 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
v1v
added a commit
to v1v/apm-agent-python
that referenced
this pull request
Oct 11, 2022
…ith-k8s-skaffold * upstream/main: bump python versions and use docker slim versions (elastic#1661) use github actions for pre-commit checks (elastic#1658) Use typing.TypeVar on decorators' type hints (elastic#1655) Use minimum of 5 seconds for interval between central config calls (elastic#1652) fix errors in pymongo tests introduced in elastic#1639 (elastic#1648) only use content-type and content-encoding headers for POSTing events (elastic#1651) fix starlette 0.21 tests (elastic#1653)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
This PR adds
typing.TypeVar
type hints to decorator methods.Related issues
Closes #1654