Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use typing.TypeVar on decorators' type hints #1655

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Use typing.TypeVar on decorators' type hints #1655

merged 2 commits into from
Oct 4, 2022

Conversation

marcoffee
Copy link
Contributor

What does this pull request do?

This PR adds typing.TypeVar type hints to decorator methods.

Related issues

Closes #1654

@cla-checker-service
Copy link

cla-checker-service bot commented Sep 30, 2022 •
edited
Loading

💚 CLA has been signed

@github-actions github-actions bot added agent-python community Issues opened by the community triage Issues awaiting triage labels Sep 30, 2022
@apmmachine
Copy link
Contributor

apmmachine commented Sep 30, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-03T17:23:51.432+0000

  • Duration: 29 min 14 sec

Test stats 🧪

Test Results
Failed 0
Passed 5014
Skipped 3378
Total 8392

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /test linters : Run the Python linters only.

  • /test full : Run the full matrix of tests.

  • /test benchmark : Run the APM Agent Python benchmarks tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@apmmachine
Copy link
Contributor

apmmachine commented Oct 3, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (67/67) 💚
Files 100.0% (227/227) 💚
Classes 100.0% (227/227) 💚
Lines 91.286% (18040/19762) 👍 1.437
Conditionals 74.58% (2796/3749) 👎 -2.57

basepi
basepi approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@basepi basepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for implementing this!

@basepi basepi requested a review from beniwohli October 3, 2022 17:26
beniwohli
beniwohli approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@beniwohli beniwohli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@beniwohli beniwohli merged commit c86c5e8 into elastic:main Oct 4, 2022
@marcoffee marcoffee deleted the use-typevar-decorators branch October 4, 2022 15:23
v1v added a commit to v1v/apm-agent-python that referenced this pull request Oct 11, 2022
@v1v
Merge remote-tracking branch 'upstream/main' into feature/unit-test-w…
a5d640e 
…ith-k8s-skaffold

* upstream/main:
  bump python versions and use docker slim versions (elastic#1661)
  use github actions for pre-commit checks (elastic#1658)
  Use typing.TypeVar on decorators' type hints (elastic#1655)
  Use minimum of 5 seconds for interval between central config calls (elastic#1652)
  fix errors in pymongo tests introduced in elastic#1639 (elastic#1648)
  only use content-type and content-encoding headers for POSTing events (elastic#1651)
  fix starlette 0.21 tests (elastic#1653)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beniwohli beniwohli beniwohli approved these changes

@basepi basepi basepi approved these changes

Assignees
No one assigned
Labels
agent-python community Issues opened by the community triage Issues awaiting triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use typing.TypeVar on methods used as annotations
4 participants
@marcoffee @apmmachine @beniwohli @basepi