Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle track_total_hits=False in elasticsearch instrumentation #1687

Merged
merged 4 commits into from
Nov 3, 2022

Conversation

basepi
Copy link
Contributor

@basepi basepi commented Nov 2, 2022

What does this pull request do?

In case track_total_hits=False, we weren't properly checking to make sure the total hits were available.

Related issues

Closes #1686

@apmmachine
Copy link
Contributor

apmmachine commented Nov 2, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-03T00:26:05.430+0000

  • Duration: 20 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 5081
Skipped 3505
Total 8586

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /test linters : Run the Python linters only.

  • /test full : Run the full matrix of tests.

  • /test benchmark : Run the APM Agent Python benchmarks tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@apmmachine
Copy link
Contributor

apmmachine commented Nov 2, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (68/68) 💚
Files 100.0% (230/230) 💚
Classes 100.0% (230/230) 💚
Lines 92.192% (18456/20019) 👍 0.008
Conditionals 75.244% (2854/3793) 👍

Copy link
Contributor

@beniwohli beniwohli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@basepi basepi merged commit 98db646 into elastic:main Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elastic APM crashes when trying to inspect hits from queries while track_total_hits is False
3 participants