-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Wrapper script #1709
[WIP] Wrapper script #1709
Conversation
🌐 Coverage report
|
It's causing some other failures. Tests pass by themselves so it's something related to cleanup on that new test, I think
@@ -163,6 +168,7 @@ markers = | |||
aiobotocore | |||
kafka | |||
grpc | |||
addopts=--random-order |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this while debugging the test failures on the old flask tests. I think we should leave it on, to try to prevent adding any tests that rely on order.
@@ -445,7 +445,7 @@ def test_backdating_transaction(elasticapm_client): | |||
elasticapm_client.begin_transaction("test", start=time.time() - 1) | |||
elasticapm_client.end_transaction() | |||
transaction = elasticapm_client.events[constants.TRANSACTION][0] | |||
assert 1000 < transaction["duration"] < 2000 | |||
assert 900 < transaction["duration"] < 2000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a windows failure:
[2023-01-11T19:42:05.004Z] elasticapm_client = <tests.fixtures.TempStoreClient object at 0x0000018EBF6B4188>
[2023-01-11T19:42:05.004Z]
[2023-01-11T19:42:05.004Z] def test_backdating_transaction(elasticapm_client):
[2023-01-11T19:42:05.004Z] elasticapm_client.begin_transaction("test", start=time.time() - 1)
[2023-01-11T19:42:05.004Z] elasticapm_client.end_transaction()
[2023-01-11T19:42:05.004Z] transaction = elasticapm_client.events[constants.TRANSACTION][0]
[2023-01-11T19:42:05.004Z] > assert 1000 < transaction["duration"] < 2000
[2023-01-11T19:42:05.004Z] E assert 1000 < 999.971
[2023-01-11T19:42:05.004Z]
[2023-01-11T19:42:05.004Z] tests\client\transaction_tests.py:448: AssertionError
I assume it's a side effect of --random-order
....or maybe it's a clock issue on the VM? I don't know. I just added some wiggle room.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one little nitpick, otherwise 👍 . Great work!
What does this pull request do?
Adds the wrapper script to automate instrumentation without code changes.
Also adds support for no-code-changes instrumentation in Flask, plus a bunch of test fixes around that.
Related issues
Closes #1019
Closes #1598