Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs note about setup code in lambda #1713

Merged
merged 3 commits into from
Jan 4, 2023
Merged

Add docs note about setup code in lambda #1713

merged 3 commits into from
Jan 4, 2023

Conversation

basepi
Copy link
Contributor

@basepi basepi commented Dec 15, 2022

Ref #1711

Also updated the CHANGELOG for GRPC and disables grpc-1.24 for now to get the nightly tests green.

@apmmachine
Copy link
Contributor

apmmachine commented Dec 15, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-04T20:59:12.602+0000

  • Duration: 28 min 8 sec

Test stats 🧪

Test Results
Failed 0
Passed 15547
Skipped 19805
Total 35352

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /test linters : Run the Python linters only.

  • /test full : Run the full matrix of tests.

  • /test benchmark : Run the APM Agent Python benchmarks tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@basepi basepi enabled auto-merge (squash) December 16, 2022 17:03
@basepi
Copy link
Contributor Author

basepi commented Jan 4, 2023

/test full

@basepi basepi disabled auto-merge January 4, 2023 20:59
Copy link
Member

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Is there anything that will track restoring gRPC testing?

@apmmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (71/71) 💚
Files 100.0% (235/235) 💚
Classes 100.0% (235/235) 💚
Lines 90.726% (18363/20240) 👎 -1.342
Conditionals 75.151% (2867/3815) 👍 0.014

@basepi
Copy link
Contributor Author

basepi commented Jan 4, 2023

Is there anything that will track restoring gRPC testing?

Yep, I planned to make an issue once I saw that the tests did indeed go green, so Beni could look at it when he was back at work.

@basepi basepi merged commit 527f62c into elastic:main Jan 4, 2023
@basepi
Copy link
Contributor Author

basepi commented Jan 4, 2023

#1718

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants