Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix blocking of gRPC stream-to-stream requests when elasticapm is enabled #1967

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Fix blocking of gRPC stream-to-stream requests when elasticapm is enabled #1967

merged 2 commits into from
Feb 13, 2024

Conversation

psydok
Copy link
Contributor

@psydok psydok commented Feb 12, 2024

What does this pull request do?

Fixed bug when connecting elasticapm to asynchronous gRPC service with multiple request types: unary-to-unary, stream-to-stream. Stream-to-stream requests were no longer processed by gRPC service.

ElasticAPM still only supports unary-to-unary requests, but it does not block other types of requests.

Related issues

Closes #1966

@cla-checker-service CLA Checker Service
Copy link

cla-checker-service bot commented Feb 12, 2024 •
edited
Loading

💚 CLA has been signed

@github-actions github-actions bot added agent-python community Issues opened by the community triage Issues awaiting triage labels Feb 12, 2024
@basepi basepi mentioned this pull request Feb 13, 2024
Closed
@basepi
Copy link
Contributor

basepi commented Feb 13, 2024

run docs-build

basepi
basepi approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@basepi basepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@basepi basepi enabled auto-merge (squash) February 13, 2024 00:45
@basepi basepi merged commit 460f141 into elastic:main Feb 13, 2024
86 checks passed
@psydok psydok deleted the fix_support_grpc branch February 15, 2024 08:30
xrmx pushed a commit that referenced this pull request Mar 20, 2024
@psydok @xrmx
Fix blocking of gRPC stream-to-stream requests when elasticapm is ena…
3b1a34b 
…bled (#1967)

* Fix gprc support with streaming requests (#1966)

* Update version.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basepi basepi basepi approved these changes

Assignees
No one assigned
Labels
agent-python community Issues opened by the community triage Issues awaiting triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[gRPC] Does not work with stream-to-stream gRPC requests
2 participants
@psydok @basepi