-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce enabled/recording settings #790
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may be missing something, but I'm not sure I can see code paths for stopping the agent when enabled
is set to False
via remote config. It appears that all enabled
code paths are only hit on startup, around starting threads and instrumenting code. We need to be able to disable the agent in mid-run as well via remote config, right?
@basepi the "spec" (a.k.a. random comment amidst lengthy discussion) says
That's the only place I'm aware of that defines behavior of these new settings. Is there any other place I missed? |
Oh! I missed that. I thought enabled was a remote config option as well. We always talk about That certainly makes things easier, thanks for the explanation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this! Definitely simpler and cleaner without having to deal with enabled
from remote config, that was the piece that I was planning to spend the most time one. Probably good you got to this one since you had internalized the requirements better than I had. 👍
💚 Build SucceededExpand to view the summary
Build stats
Test stats 🧪
|
@beniwohli if this is ready let's get it merged on Monday and cut a new release early next week. |
instance.address is not set on those versions
* introduce enabled/recording settings see elastic/apm#92 (comment) Co-authored-by: Colton Myers <colton.myers@gmail.com>
* introduce enabled/recording settings see elastic/apm#92 (comment) Co-authored-by: Colton Myers <colton.myers@gmail.com>
* introduce enabled/recording settings see elastic/apm#92 (comment) Co-authored-by: Colton Myers <colton.myers@gmail.com>
What does this pull request do?
Introduce
recording
/enabled
as per elastic/apm#92 (comment)