Check for missing elasticapm_client in tornado instrumentation #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to try to figure out how to write a test for this tomorrow. |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
|
Great catch! Something to keep in mind for any new framework integrations that use instrumentation in the future |
romulorosa
pushed a commit
to romulorosa/apm-agent-python
that referenced
this pull request
Oct 15, 2020
…ic#813) * Check for missing elasticapm_client in tornado instrumentation * Add a test
romulorosa
pushed a commit
to romulorosa/apm-agent-python
that referenced
this pull request
Oct 15, 2020
…ic#813) * Check for missing elasticapm_client in tornado instrumentation * Add a test
beniwohli
pushed a commit
to beniwohli/apm-agent-python
that referenced
this pull request
Sep 14, 2021
…ic#813) * Check for missing elasticapm_client in tornado instrumentation * Add a test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
If
tornadois in use but not as the "main" instrumented framework (such as withflower), the instrumentation throws an error because the elasticapm_client cannot be found.This PR checks for that case and skips all of the instrumentation work.
Related issues
Closes #811