Add some error handling around frame processing #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
beniwohli
approved these changes
May 28, 2020
romulorosa
pushed a commit
to romulorosa/apm-agent-python
that referenced
this pull request
Oct 15, 2020
* Add some error handling around frame processing See https://discuss.elastic.co/t/python-agent-raise-valueerror/233263 * Add a log to make sure the user doesn't wonder where the frames are * Use `break` instead of `continue` * Add to changelog
romulorosa
pushed a commit
to romulorosa/apm-agent-python
that referenced
this pull request
Oct 15, 2020
* Add some error handling around frame processing See https://discuss.elastic.co/t/python-agent-raise-valueerror/233263 * Add a log to make sure the user doesn't wonder where the frames are * Use `break` instead of `continue` * Add to changelog
beniwohli
pushed a commit
to beniwohli/apm-agent-python
that referenced
this pull request
Sep 14, 2021
* Add some error handling around frame processing See https://discuss.elastic.co/t/python-agent-raise-valueerror/233263 * Add a log to make sure the user doesn't wonder where the frames are * Use `break` instead of `continue` * Add to changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://discuss.elastic.co/t/python-agent-raise-valueerror/233263
This is not an ideal solution, but I've investigated every code path into this function and I cannot see how the user could see that error. For now we'll just avoid throwing the error and see if any other users see it.