Add support for AsyncElasticsearch #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Log outputExpand to view the last 100 lines of log output
|
basepi
approved these changes
Jun 2, 2020
romulorosa
pushed a commit
to romulorosa/apm-agent-python
that referenced
this pull request
Oct 15, 2020
* Add support for AsyncElasticsearch * Add to changelog Co-authored-by: Colton Myers <colton.myers@gmail.com>
romulorosa
pushed a commit
to romulorosa/apm-agent-python
that referenced
this pull request
Oct 15, 2020
* Add support for AsyncElasticsearch * Add to changelog Co-authored-by: Colton Myers <colton.myers@gmail.com>
beniwohli
pushed a commit
to beniwohli/apm-agent-python
that referenced
this pull request
Sep 14, 2021
* Add support for AsyncElasticsearch * Add to changelog Co-authored-by: Colton Myers <colton.myers@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Adds support for
elasticsearch.AsyncElasticsearchwhich is going to be released with elasticsearch-py v7.8.0. I ran the test suite againstelasticsearch==7.8.0a1which passed but left the requirements file to only use released versions.Let me know if any of the changes to the existing ES instrumentation shouldn't be modified. I made these changes under the impression that these were private APIs :)