-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include whole body for elasticsearch-py queries #940
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://discuss.elastic.co/t/apm-not-showing-aggregation/250762 for context. Basically, by only including the query, we risk missing very useful pieces of the query for diagnosing issues -- `aggs` is the big problem here but I don't see why the user wouldn't want the entire query every time.
sethmlarson
approved these changes
Oct 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Since the JSON structure is not relevant to machines, more relevant to users this isn't going to break anything I'm assuming :)
romulorosa
pushed a commit
to romulorosa/apm-agent-python
that referenced
this pull request
Oct 15, 2020
* Include whole body for elasticsearch queries See https://discuss.elastic.co/t/apm-not-showing-aggregation/250762 for context. Basically, by only including the query, we risk missing very useful pieces of the query for diagnosing issues -- `aggs` is the big problem here but I don't see why the user wouldn't want the entire query every time. * Add changelog * Fix test to use text.keyword to sort * Use an int field (why is .keyword missing?) * Fix the _source check and fix async tests * Fix json sorting * Fix the *other* async elasticsearch tests... * Allow for any sorting order by json * So much copy pasta
romulorosa
pushed a commit
to romulorosa/apm-agent-python
that referenced
this pull request
Oct 15, 2020
* Include whole body for elasticsearch queries See https://discuss.elastic.co/t/apm-not-showing-aggregation/250762 for context. Basically, by only including the query, we risk missing very useful pieces of the query for diagnosing issues -- `aggs` is the big problem here but I don't see why the user wouldn't want the entire query every time. * Add changelog * Fix test to use text.keyword to sort * Use an int field (why is .keyword missing?) * Fix the _source check and fix async tests * Fix json sorting * Fix the *other* async elasticsearch tests... * Allow for any sorting order by json * So much copy pasta
beniwohli
pushed a commit
to beniwohli/apm-agent-python
that referenced
this pull request
Sep 14, 2021
* Include whole body for elasticsearch queries See https://discuss.elastic.co/t/apm-not-showing-aggregation/250762 for context. Basically, by only including the query, we risk missing very useful pieces of the query for diagnosing issues -- `aggs` is the big problem here but I don't see why the user wouldn't want the entire query every time. * Add changelog * Fix test to use text.keyword to sort * Use an int field (why is .keyword missing?) * Fix the _source check and fix async tests * Fix json sorting * Fix the *other* async elasticsearch tests... * Allow for any sorting order by json * So much copy pasta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://discuss.elastic.co/t/apm-not-showing-aggregation/250762
for context.
Basically, by only including the query, we risk missing very useful
pieces of the query for diagnosing issues --
aggs
is the big problemhere but I don't see why the user wouldn't want the entire query every
time.