Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add protobuf utils and improve compatibility for easier migration #57

Merged
merged 2 commits into from
Jun 12, 2023
Merged

feat: add protobuf utils and improve compatibility for easier migration #57

merged 2 commits into from
Jun 12, 2023

Conversation

kruskall
Copy link
Member

@kruskall kruskall commented Jun 12, 2023 •
edited
Loading

This PR is adding a few methods for easier migration to protobuf in APM Server:

  • ToModelProtobuf is made public to allow converting from classic/old model to protobuf modelpb
  • Add a ProtoBatchProcessor as a compatibility layer between model.BatchProcessor and modelpb.BatchProcessor
  • Add modelpb.BatchProcessor: required for migrating to protobuf
  • modelpb labels: these are type aliases with utility methods, similar to what we have for the classic/old models
  • url utility methods similar to what we had for the classic/old models

Related to #52

@kruskall kruskall requested a review from a team June 12, 2023 13:58
@kruskall kruskall mentioned this pull request Jun 12, 2023
Merged
@kruskall kruskall requested a review from dmathieu June 12, 2023 14:15
@kruskall kruskall merged commit 68db40a into elastic:main Jun 12, 2023
@kruskall kruskall deleted the feat/pb-utils branch June 12, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmathieu dmathieu dmathieu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kruskall @dmathieu