Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate metadata decoding to protobuf #67

Merged
merged 7 commits into from
Jun 19, 2023
Merged

feat: migrate metadata decoding to protobuf #67

merged 7 commits into from
Jun 19, 2023

Commits on Jun 18, 2023

  1. feat: migrate metadata decoding to protobuf

    @kruskall
    kruskall committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    9b5d354 View commit details
    Browse the repository at this point in the history

  2. fix: add nil check and resolve fuzz testing issues

    @kruskall
    kruskall committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    f04a0b7 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2023

  1. test: fix data race in TestConcurrentAsync 

    We were previously using a struct so this wasn't obvious. Now that we
are passing a pointer we can't share the modelpb.APMEvent because the
readMetadata is called before cloning the base event.
The data race only happens in the test because of how it's written.
Production code (APM Server) is not sharing APMEvents.
    @kruskall
    kruskall committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    18b0ebc View commit details
    Browse the repository at this point in the history

  2. Unskip tests

    @axw @kruskall
    axw authored and kruskall committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    3a3bab4 View commit details
    Browse the repository at this point in the history

  3. build: run tests with race detector

    @kruskall
    kruskall committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    8605d92 View commit details
    Browse the repository at this point in the history

  4. refactor: fix build errors

    @kruskall
    kruskall committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    e6b15bc View commit details
    Browse the repository at this point in the history

  5. build: remove race detector from tests

    @kruskall
    kruskall committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    d5b63d2 View commit details
    Browse the repository at this point in the history