Skip to content

Commit

Permalink
feat: retry in case vault is not reachable (#107)
Browse files Browse the repository at this point in the history
  • Loading branch information
v1v authored Jul 4, 2019
1 parent 0ec5cb7 commit 9a58bcf
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
5 changes: 5 additions & 0 deletions src/test/groovy/GetVaultSecretStepTests.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,11 @@ class GetVaultSecretStepTests extends BasePipelineTest {
def script = loadScript("vars/toJSON.groovy")
return script.call(s)
})
helper.registerAllowedMethod("retry", [Integer.class, Closure.class], { i, c ->
c.call()
})
helper.registerAllowedMethod("randomNumber", [Map.class], { m -> return m.min })
helper.registerAllowedMethod("sleep", [Integer.class], { 'OK' })
}

@Test
Expand Down
7 changes: 5 additions & 2 deletions vars/getVaultSecret.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,11 @@ def readSecret(secret){
string(credentialsId: 'vault-addr', variable: 'VAULT_ADDR'),
string(credentialsId: 'vault-role-id', variable: 'VAULT_ROLE_ID'),
string(credentialsId: 'vault-secret-id', variable: 'VAULT_SECRET_ID')]) {
def token = getVaultToken(env.VAULT_ADDR, env.VAULT_ROLE_ID, env.VAULT_SECRET_ID)
props = getVaultSecretObject(env.VAULT_ADDR, secret, token)
retry(2) {
sleep randomNumber(min: 5, max: 10)
def token = getVaultToken(env.VAULT_ADDR, env.VAULT_ROLE_ID, env.VAULT_SECRET_ID)
props = getVaultSecretObject(env.VAULT_ADDR, secret, token)
}
//we do not have permissions to revoke a token.
//revokeToken(env.VAULT_ADDR, token)
}
Expand Down

0 comments on commit 9a58bcf

Please sign in to comment.