Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Cache Oracle Instant Client Docker Image #100

Merged
merged 1 commit into from
Jun 28, 2019
Merged

ci: Cache Oracle Instant Client Docker Image #100

merged 1 commit into from
Jun 28, 2019

Conversation

kuisathaverat
Copy link
Contributor

put Oracle Instant Client Docker Image in the docker.elastic.co registry

@kuisathaverat kuisathaverat self-assigned this Jun 27, 2019
v1v
v1v approved these changes Jun 27, 2019
View reviewed changes
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ . could we create a def method to run the script section for weblogic:12.2.1.3-dev and database-instantclient:12.2.0.1 then do the call?

mdelapenya
mdelapenya approved these changes Jun 27, 2019
View reviewed changes
Copy link
Contributor

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

image

@kuisathaverat kuisathaverat merged commit f7d2fc7 into elastic:master Jun 28, 2019
@kuisathaverat kuisathaverat deleted the ci/oracle-instant-client-cache branch July 1, 2020 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdelapenya mdelapenya mdelapenya approved these changes

@v1v v1v v1v approved these changes

Assignees

@kuisathaverat kuisathaverat

Labels
automation ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kuisathaverat @mdelapenya @v1v