Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable junit reporting for the pre-commit stage #154

Merged
merged 7 commits into from
Jul 26, 2019
Merged

enable junit reporting for the pre-commit stage #154

merged 7 commits into from
Jul 26, 2019

Conversation

v1v
Copy link
Member

@v1v v1v commented Jul 26, 2019 •
edited
Loading

Highlights

  • Let's report the pre-commit output as JUnit now.
  • Add another case for the Skipped rules.

Test cases

  • Local pre-commit execution generates the same test output in JUnit

image

image

@v1v v1v added enhancement New feature or request automation labels Jul 26, 2019
@v1v v1v self-assigned this Jul 26, 2019
@v1v v1v changed the title enable junit reporting for the pre-commit stage WIP enable junit reporting for the pre-commit stage Jul 26, 2019
@v1v v1v force-pushed the feature/pre-commit-report branch from 8d541dc to 00aa052 Compare July 26, 2019 14:20
@v1v v1v changed the title WIP enable junit reporting for the pre-commit stage enable junit reporting for the pre-commit stage Jul 26, 2019
@v1v v1v added the ci label Jul 26, 2019
@v1v v1v merged commit f05b1e5 into elastic:master Jul 26, 2019
@v1v v1v deleted the feature/pre-commit-report branch July 26, 2019 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdelapenya mdelapenya mdelapenya left review comments

@kuisathaverat kuisathaverat kuisathaverat approved these changes

Assignees

@v1v v1v

Labels
automation ci enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v1v @mdelapenya @kuisathaverat