Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: build version might differ when using aliases #208

Merged
merged 1 commit into from
Sep 2, 2019
Merged

fix: build version might differ when using aliases #208

merged 1 commit into from
Sep 2, 2019

Conversation

v1v
Copy link
Member

@v1v v1v commented Sep 2, 2019

Highlights

  • When using alias the version need to be collected.

Test Cases

  • Used to be
> sh resources/scripts/getDockerImages.sh 7.4-SNAPSHOT

> echo $?
1
  • Now
> sh resources/scripts/getDockerImages.sh 7.4-SNAPSHOT
Downloading elasticsearch - https://snapshots.elastic.co/7.4.0-809769f8/downloads/elasticsearch/elasticsearch-7.4.0-SNAPSHOT-docker-image.tar.gz
Downloading kibana - https://snapshots.elastic.co/7.4.0-809769f8/downloads/kibana/kibana-7.4.0-SNAPSHOT-docker-image.tar.gz
Downloading apm-server - https://snapshots.elastic.co/7.4.0-809769f8/downloads/apm-server/apm-server-7.4.0-SNAPSHOT-docker-image.tar.gz
Downloading auditbeat - https://snapshots.elastic.co/7.4.0-809769f8/downloads/beats/auditbeat/auditbeat-7.4.0-SNAPSHOT-docker-image-linux-amd64.tar.gz
Downloading filebeat - https://snapshots.elastic.co/7.4.0-809769f8/downloads/beats/filebeat/filebeat-7.4.0-SNAPSHOT-docker-image-linux-amd64.tar.gz
Downloading heartbeat - https://snapshots.elastic.co/7.4.0-809769f8/downloads/beats/heartbeat/heartbeat-7.4.0-SNAPSHOT-docker-image-linux-amd64.tar.gz
Downloading metricbeat - https://snapshots.elastic.co/7.4.0-809769f8/downloads/beats/metricbeat/metricbeat-7.4.0-SNAPSHOT-docker-image-linux-amd64.tar.gz
Downloading packetbeat - https://snapshots.elastic.co/7.4.0-809769f8/downloads/beats/packetbeat/packetbeat-7.4.0-SNAPSHOT-docker-image-linux-amd64.tar.gz

> echo $?
0

@v1v v1v added bug Something isn't working automation labels Sep 2, 2019
@v1v v1v self-assigned this Sep 2, 2019
mdelapenya
mdelapenya approved these changes Sep 2, 2019
View reviewed changes
Copy link
Contributor

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

image

@v1v v1v merged commit 8f79295 into elastic:master Sep 2, 2019
@v1v v1v deleted the fix/pullDocker branch September 2, 2019 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdelapenya mdelapenya mdelapenya approved these changes

@kuisathaverat kuisathaverat kuisathaverat approved these changes

Assignees

@v1v v1v

Labels
automation bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v1v @mdelapenya @kuisathaverat