-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable opbeans pipeline #230
Conversation
@@ -16,7 +16,7 @@ repos: | |||
- id: check-xml | |||
exclude: ^target/ | |||
- id: end-of-file-fixer | |||
exclude: (^src/test/resources/preCommitToJunit/output|^target/) | |||
exclude: (^src/test/resources/preCommitToJunit/output|^target/|^vars/README.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The automation to generate the README.md should not be affected by this hook.
def script = loadScript(scriptName) | ||
script.call() | ||
printCallStack() | ||
assertTrue(helper.callStack.findAll { call -> call.methodName == 'stage' }.any { call -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: we will have to refactor this calls to grab stages, steps, whatever we need on a helper class (on in this PR).
env.BRANCH_NAME = 'master' | ||
binding.setVariable('env', env) | ||
|
||
registerDeclarativeMethods() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loved this separation of concerns!!
Causes by https://github.com/elastic/observability-dev/issues/137
Highlights
Tasks