(#213) Install Go in the build agent before installing mage #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuisathaverat
approved these changes
Nov 25, 2019
v1v
approved these changes
Nov 25, 2019
We'll use a file at workspace, but it could be overriden by an environment variable, that will allow using different Go versions
This was referenced Nov 25, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Install Go in the build agent before installing Mage. The install script comes from Travis CI's GIMME
We will read Go version from a file next to the script (.go_version), or using the GO_VERSION env var. Default value if none of them exists is
1.12.7Why is it important?
I tested the local environment against a local worker so obviously all build tools were installed in the machine.
Related issues
Completes #276
Relates #213