ci(jenkins): enable PR notification #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1v
commented
Apr 24, 2020
| cleanup { | ||
| notifyBuildResult() | ||
| notifyBuildResult(prComment: true) |
There was a problem hiding this comment.
Flag to enable the comment in the GitHub PRs, then the rollout could be per project or globally :)
| @@ -0,0 +1,82 @@ | |||
| ## ${statusSuccess ? ':green_heart: Build Succeeded' : ':broken_heart: Build Failed'} | |||
There was a problem hiding this comment.
For instance:
It's the output generated with the test resources files when running the UTs
There was a problem hiding this comment.
I'd see convenient naming this template including "github-comment", something like:
groovy-markdown-custom-github-commentgroovy-markdown-custom-gh-commentmarkdown-custom-github-comment(maybe groovy could be omitted as implicit default)
I think it will add context to the reader when accessing this document. Wdyt?
There was a problem hiding this comment.
See 0a00f8fc079a80962a15df05bdff566595f9ca22 , in other words, using github-comment-markdown.template since groovy and custom are not necessarily required as you spotted :)
| "testsErrors": testsErrors, | ||
| "testsSummary": testsSummary | ||
| ]) | ||
| githubPrComment(message: body) |
There was a problem hiding this comment.
githubPrComment got already a default template, so let's force the message to keep backward compatibility
| @@ -88,5 +92,5 @@ def getLatestBuildComment() { | |||
| def comments = getComments() | |||
| return comments | |||
| .reverse() | |||
| .find { (it.user.login == 'elasticmachine') && it.body =~ /<!--PIPELINE/ } | |||
| .find { (it.user.login == 'elasticmachine' || it.user.login == 'apmmachine') && it.body =~ /<!--PIPELINE/ } | |||
There was a problem hiding this comment.
Since we got a new service account the github pr comment reusiing approach was broken
…ions * upstream/master: docs: update CHANGELOG.md [maven-release-plugin] prepare for next development iteration [maven-release-plugin] prepare release v1.1.90 ci: jq is not installed in the master (#486)
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Log outputExpand to view the last 100 lines of log output
|
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
This reverts commit 36614f8.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Log outputExpand to view the last 100 lines of log output
|
This reverts commit 65ddf73.
This reverts commit 0f7e60e.
|
The URLs have a
|
v1v
commented
Apr 24, 2020
Indeed, I'm testing it with my local jenkins instance:
|
mdelapenya
approved these changes
Apr 24, 2020
kuisathaverat
approved these changes
Apr 24, 2020
v1v
force-pushed
the
feature/notifications
branch
from
0a00f8f
to
48a1599
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Why is it important?
Centralise the notifications and keep the information simple, therefore we can enhance the comment as much as required and build the reuse comment strategy.
Related issues
Caused by https://github.com/elastic/observability-robots/issues/37
Follow-ups
Tests
See #488 (comment) which has been generated when running the MBP in my local jenkins instance.
See #488 (comment) for a broken test build.
Reuse comment seems to be back to business