Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

ci: stash/unstash steps with Google Cloud Storage #531

Merged
merged 11 commits into from
May 14, 2020

Conversation

v1v
Copy link
Member

@v1v v1v commented May 13, 2020

What does this PR do?

  • Provide an alternative to the built-in stash/unstash built-in steps.
  • Storage rotation is delegated to the bucket itself.

Why is it important?

Will allow to run the pipelines faster.

Related issues

Caused by elastic/beats#18473

Tasks

  • Run manual tests
  • Validate if the strip folder from the google storage upload step can help with the move/mv commands

Tests

Real scenarios

build

ITs

image

@v1v v1v self-assigned this May 13, 2020
@v1v v1v added the automation label May 13, 2020
@botelastic botelastic bot added the groovy label May 13, 2020
@v1v v1v changed the title fix: null build description ci: support stash/unstash with GCS May 13, 2020
@v1v v1v added the enhancement New feature or request label May 13, 2020
@v1v v1v changed the title ci: support stash/unstash with GCS WIP ci: support stash/unstash with GCS May 13, 2020
vars/stashV2.groovy Outdated Show resolved Hide resolved
@apmmachine
Copy link
Contributor

apmmachine commented May 13, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 0
Passed 524
Skipped 9
Total 533

v1v added 4 commits May 14, 2020 08:01
… into feature/stashv2

* 'feature/stashv2' of github.com:v1v/apm-pipeline-library:
  Write credentials for opbot (#529)
  Add flake detector to pipeline (#530)
@botelastic botelastic bot added the master label May 14, 2020
@v1v v1v marked this pull request as ready for review May 14, 2020 07:45
@@ -93,7 +93,6 @@ unclassified:
filterSettings:
includeFilter: false
selectors:
- wildcard: "*.*"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix an issue

@v1v v1v changed the title WIP ci: support stash/unstash with GCS ci: support stash/unstash with GCS May 14, 2020
@v1v v1v requested a review from a team May 14, 2020 07:46
@cachedout
Copy link
Contributor

If configuring a retention policy and possibly other parameters on the Google side are necessary, should that process be documented in this PR?

@v1v
Copy link
Member Author

v1v commented May 14, 2020

@cachedout good point, I just pushed 84734aa#diff-64f8c926883b22c4ce3299295ee2235fR32

vars/README.md Outdated Show resolved Hide resolved
vars/unstashV2.groovy Outdated Show resolved Hide resolved
vars/unstashV2.txt Outdated Show resolved Hide resolved
Co-authored-by: cachedout <mike.place@elastic.co>
@v1v v1v merged commit 38f6835 into elastic:master May 14, 2020
@v1v v1v changed the title ci: support stash/unstash with GCS ci: stash/unstash steps with Google Cloud Storage May 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants