This repository has been archived by the owner on Oct 28, 2024. It is now read-only.
tar step supports windows #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1v
commented
Jun 12, 2020
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
kuisathaverat
approved these changes
Jun 15, 2020
cachedout
approved these changes
Jun 15, 2020
| @@ -1139,6 +1139,7 @@ notifyBuildResult(es: 'http://elastisearch.example.com:9200', secret: 'secret/te | |||
| * shouldNotify: boolean value to decide to send or not the email notifications, by default it send | |||
| emails on Failed builds that are not pull request. | |||
| * prComment: Whether to add a comment in the PR with the build summary as a comment. Default: `true`. | |||
| * analyzeFlakey: Whether or not to add a comment in the PR with tests which have been detected as flakey. Default: `false`. | |||
There was a problem hiding this comment.
Ah, cool. Thanks for grabbing this!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
pathPrefixparameter in favor of the--excludeflag for thetarcommand.failNeverparameter to force a failure if any errors in the step rather than setting the build as unstable.tarstep in thestashV2step.Why is it important?
To support some other scenarios that we have already covered with the
stashv2stepRelated issues
Caused by elastic/beats#18695
Tests
expected unstable status, that has been validated with an assertion in the ITs.
Tasks