This repository has been archived by the owner on Oct 28, 2024. It is now read-only.
Support slack comments for builds #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1v
commented
Sep 30, 2020
resources/slack-markdown.template
Outdated
| @@ -0,0 +1,39 @@ | |||
| <%if (statusSuccess) {%> | |||
There was a problem hiding this comment.
This is required to be customised with the slack format
v1v
commented
Sep 30, 2020
v1v
commented
Sep 30, 2020
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
kuisathaverat
approved these changes
Sep 30, 2020
kuisathaverat
approved these changes
Oct 1, 2020
mdelapenya
reviewed
Oct 2, 2020
mdelapenya
reviewed
Oct 2, 2020
vars/notifyBuildResult.groovy
Outdated
Comment on lines
48
to
50
| def slackChannel = args.containsKey('slackChannel') ? args.slackChannel : env.SLACK_CHANNEL | ||
| def slackAlways = args.containsKey('slackAlways') ? args.slackAlways : (currentBuild.currentResult != "SUCCESS") | ||
| def slackCredentials = args.containsKey('slackCredentials') ? args.slackCredentials : 'jenkins-slack-integration-token' |
There was a problem hiding this comment.
Should we update the examples in the header comments too?
mdelapenya
approved these changes
Oct 2, 2020
…ry into test/slackComment * 'test/slackComment' of github.com:v1v/apm-pipeline-library: docs: update CHANGELOG.md [maven-release-plugin] prepare for next development iteration [maven-release-plugin] prepare release v1.1.143 fix branch when on a PR basis (#737)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enable slack comments as part of the notifyBuildStatus step
Why is it important?
Easy to provide context what's going on without the need to access to the CI or even GitHub.
This will enable us to send notifications when builds are failing in the master branch or any release branches.
Related issues
Caused by elastic/beats#21428
Tests
Follow ups