Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.14.2: add missing changelog entry #13555

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Conversation

endorama
Copy link
Member

@endorama endorama commented Jul 3, 2024

Intially only merged on 8.14 branch, should have been merged on
main and backported.

Also add a missing changelog entry

Intially only merged on 8.14 branch, should have been merged on
main and backported.

Also add a missing changelog entry
@endorama endorama requested a review from a team as a code owner July 3, 2024 09:25
Copy link
Contributor

mergify bot commented Jul 3, 2024

This pull request does not have a backport label. Could you fix it @endorama? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jul 3, 2024
@kruskall kruskall added backport-8.14 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Jul 3, 2024
@endorama endorama enabled auto-merge (squash) July 3, 2024 09:29
Copy link
Member

@carsonip carsonip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should only be merged when the version is released

@carsonip carsonip disabled auto-merge July 3, 2024 09:42
@carsonip carsonip changed the title 8.14.3: add missing changelog entry 8.14.2: add missing changelog entry Jul 3, 2024
@kruskall
Copy link
Member

kruskall commented Jul 3, 2024

should only be merged when the version is released

Why ? This is just a changelog entry, am I missing something ?

Copy link
Member

@carsonip carsonip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got confirmation from docs team: it is good to merge on release day or D-1.

@endorama endorama enabled auto-merge (squash) July 4, 2024 07:41
@endorama endorama merged commit b99e36b into elastic:main Jul 4, 2024
7 checks passed
mergify bot pushed a commit that referenced this pull request Jul 4, 2024
Intially only merged on 8.14 branch, should have been merged on
main and backported.

Also add a missing changelog entry

(cherry picked from commit b99e36b)

# Conflicts:
#	changelogs/8.14.asciidoc
@endorama endorama deleted the 8.14.2-changelog branch July 4, 2024 08:22
mergify bot added a commit that referenced this pull request Jul 4, 2024
* 8.14.2: add missing changelog entry (#13555)

Intially only merged on 8.14 branch, should have been merged on
main and backported.

Also add a missing changelog entry

(cherry picked from commit b99e36b)

# Conflicts:
#	changelogs/8.14.asciidoc

* resolve conflicts

---------

Co-authored-by: Edoardo Tenani <526307+endorama@users.noreply.github.com>
Co-authored-by: Edoardo Tenani <edoardo.tenani@elastic.co>
marclop pushed a commit that referenced this pull request Jul 5, 2024
* 8.14.2: add missing changelog entry (#13555)

Intially only merged on 8.14 branch, should have been merged on
main and backported.

Also add a missing changelog entry

(cherry picked from commit b99e36b)

# Conflicts:
#	changelogs/8.14.asciidoc

* resolve conflicts

---------

Co-authored-by: Edoardo Tenani <526307+endorama@users.noreply.github.com>
Co-authored-by: Edoardo Tenani <edoardo.tenani@elastic.co>
Signed-off-by: Marc Lopez Rubio <marc5.12@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.14 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants